-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Rename MemSQL docs to SingleStore #16223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't seem as if anything else links to this page.
I didn't rename this page intentionally because I have concerns about external usages (=not managed in this repository). We don't care about it? Relates to #15467
|
Yeah .. we want to look at the redirect stuff in parallel |
It's possible some pages aren't indexed by google, but I can't find an external link to our memsql/singlestore docs at all. |
|
@electrum @jhlodin borrowing from #15467, I've added a redirect plugin to this PR. To allow the build to function for now, I've removed the "-W" flag, which no longer treats build warnings as errors. I've opened up a pull request for the plugin to fix the warning, and once that's included, we can re-add the -W flag. |
|
Note that this would require a new Sphinx docker image (with the new redirects plugin) to be pushed to |
0a86154 to
34692f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How? Maybe link to issue and also detail what version was modified .. so we can figure it out a bit easier in the future
34692f5 to
f4b7f8d
Compare
ebyhr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commit order is wrong. "Add redirects extension ..." should be the 1st.
f4b7f8d to
95740f0
Compare
95740f0 to
473c12a
Compare
473c12a to
e9f14e6
Compare
mosabua
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now. Lets make sure we check upstream now and then and see if they cut a release .. then we can get rid of the inline redirect and build a new container image and use that.
Description
We've fully deprecated the memsql name, so we should change the name of the .rst file so it appears as "singlestore.html" in the browser URL. Tested & built locally, doesn't seem as if anything else links to this page.
Additional context and related issues
Follow-up to #16180
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: