Expose delta.default-reader-version and delta.default-writer-version delta lake configuration properties#16208
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Feb 24, 2023
Conversation
krvikash
force-pushed
the
trino-16165-follow-up
branch
from
4501af5 to
d529cb8
Compare
ebyhr
reviewed
Feb 22, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
trino-16165-follow-up
branch
from
d529cb8 to
c12f3a6
Compare
Contributor
Author
|
Thank @ebyhr for the review. Addressed comments. |
ebyhr
reviewed
Feb 22, 2023
plugin/trino-delta-lake/src/test/java/io/trino/plugin/deltalake/TestDeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
pajaks
reviewed
Feb 22, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeMinioConnectorTest.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
trino-16165-follow-up
branch
from
c12f3a6 to
b7205d8
Compare
ebyhr
requested changes
Feb 22, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
trino-16165-follow-up
branch
from
b7205d8 to
96a8a7a
Compare
ebyhr
reviewed
Feb 22, 2023
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Commit granularity seems wrong. Adding config properties without actual usage doesn't make sense. I would recommend squashing three commits into one.
krvikash
force-pushed
the
trino-16165-follow-up
branch
from
96a8a7a to
9673253
Compare
ebyhr
approved these changes
Feb 23, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
krvikash
force-pushed
the
trino-16165-follow-up
branch
2 times, most recently
from
7b61cde to
8f3306a
Compare
krvikash
changed the title
delta.reader-version and delta.writer-version delta lake configuration propertiesdelta.default-reader-version and delta.default-writer-version delta lake configuration properties
krvikash
force-pushed
the
trino-16165-follow-up
branch
from
8f3306a to
0326b9e
Compare
Member
|
/test-with-secrets sha=0326b9e5680df72d04db320e6c223590d609c3cf |
alexjo2144
approved these changes
Feb 23, 2023
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeConfig.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
trino-16165-follow-up
branch
from
0326b9e to
b62941f
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up of #16165 (comment)
Release notes
(X) Release notes are required, with the following suggested text: