Remove unnecessary directory checks in delta lake#16200
Remove unnecessary directory checks in delta lake#16200findepi merged 2 commits intotrinodb:masterfrom pajaks:pajaks/remove_hdfs_filesytem
Conversation
|
/test-with-secrets sha=6866240318db76360cebff85c9ca0432f9251395 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4233580804 |
There was a problem hiding this comment.
This check can be skipped because directory is created implicitly when first file is created.
There was a problem hiding this comment.
This should be part of the commit message
There was a problem hiding this comment.
This seems to be redundant check, as individual files (and implicitly directories) are created at this point. If location would be file it should fail during directory creation earlier.
plugin/trino-delta-lake/src/main/java/io/trino/plugin/deltalake/DeltaLakeMetadata.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This should be part of the commit message
|
nit: I would include "in Delta Lake" or something to commit titles. |
Ensuring that path exists can be skipped because directory is created implicitly when first file is created.
|
Commit message changed. |
|
@pajaks Was there any change since last review except for the commit title? We don't need to run CI if the change is only commit title. |
Only commit title changes since last review, but there was other changes since last run with secret. |
|
/test-with-secrets sha=ddf985373d9fcabbe8299798b453526ef69de737 |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4342318738 |
this means that |
Description
Origin of this change is to migrate to
TrinoFileSystemRelates to #16020
Additional context and related issues
Release notes
(x ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: