Skip to content

Add a metadata table showing commits in Hudi connector#16181

Merged
ebyhr merged 2 commits intotrinodb:masterfrom
albericgenius:snapshots
Mar 20, 2023
Merged

Add a metadata table showing commits in Hudi connector#16181
ebyhr merged 2 commits intotrinodb:masterfrom
albericgenius:snapshots

Conversation

@albericgenius
Copy link
Copy Markdown
Contributor

@albericgenius albericgenius commented Feb 20, 2023 •
edited by ebyhr
Loading

Description

Fix #16149

  • add the Timeline table to show commits in Hudi connector

Release notes

(x) Release notes are required, with the following suggested text:

# Hudi
* Add a `$timeline` system table which can be queried to inspect Hudi table timeline. ({issue}`16149`)

@cla-bot cla-bot bot added the cla-signed label Feb 20, 2023
@albericgenius albericgenius requested a review from ebyhr February 20, 2023 07:56
@ebyhr ebyhr mentioned this pull request Feb 20, 2023
Closed
@ebyhr ebyhr requested a review from findinpath February 20, 2023 08:25
@findinpath
Copy link
Copy Markdown
Contributor

findinpath commented Feb 20, 2023

Please add documentation about the new system table in hudi.rst.

findinpath
findinpath reviewed Feb 20, 2023
View reviewed changes
@github-actions github-actions bot added the docs label Feb 21, 2023
@albericgenius
Copy link
Copy Markdown
Contributor Author

albericgenius commented Feb 21, 2023

There is UI CI issue #16179, the failed test case is not relative to this PR.

ebyhr
ebyhr reviewed Feb 22, 2023
View reviewed changes
@ebyhr ebyhr self-requested a review February 22, 2023 23:39
@albericgenius albericgenius force-pushed the snapshots branch 2 times, most recently from 2c606a7 to 58ee60f Compare February 23, 2023 13:19
findinpath
findinpath reviewed Feb 23, 2023
View reviewed changes
ebyhr
ebyhr reviewed Mar 3, 2023
View reviewed changes
plugin/trino-hudi/src/main/java/io/trino/plugin/hudi/TimelineTable.java Outdated
Copy link
Copy Markdown
Member

@ebyhr ebyhr Mar 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will materialize all active timelines in my understanding. It would be nice to avoid it for avoiding high memory usage.

@github-actions github-actions bot added the hudi Hudi connector label Mar 6, 2023
@albericgenius albericgenius requested a review from ebyhr March 6, 2023 10:16
ebyhr
ebyhr reviewed Mar 14, 2023
View reviewed changes
@albericgenius albericgenius requested a review from ebyhr March 14, 2023 07:40
@ebyhr ebyhr merged commit 7927d79 into trinodb:master Mar 20, 2023
@ebyhr ebyhr mentioned this pull request Mar 20, 2023
Closed
@github-actions github-actions bot added this to the 411 milestone Mar 20, 2023
@colebow colebow mentioned this pull request Mar 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@findinpath findinpath Awaiting requested review from findinpath

@ebyhr ebyhr Awaiting requested review from ebyhr

Assignees

No one assigned

Labels

cla-signed docs hudi Hudi connector

Milestone

411

Development

Successfully merging this pull request may close these issues.

Add a metadata table showing commits in Hudi connector

3 participants

@albericgenius @findinpath @ebyhr