Add CLI options for history file and pager#16151
Merged
kokosing merged 1 commit intotrinodb:masterfrom Feb 23, 2023
Merged
Conversation
Member
Author
|
@kokosing this is ready to go, PTAL. |
nineinchnick
force-pushed
the
cli-pager-histfile
branch
from
f843272 to
cb59470
Compare
Member
|
The CI is failing. Is it related? |
nineinchnick
force-pushed
the
cli-pager-histfile
branch
from
cb59470 to
703c215
Compare
Member
Author
No, the issues in web ui job should be already fixed on master, I rebased. |
Member
I think it is user-visible change and docs are release notes are required. @nineinchnick Please provide content. |
Member
|
Thanks, merged |
Member
Author
|
I updated the PR description with suggested release notes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add CLI options for pager and history file, which previously could only be set using environmental variables. Having them available as options allows setting them in the configuration file.
Extracted from #12208
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: