Do not mark already closed connection as to be reused#16121
Merged
kokosing merged 1 commit intotrinodb:masterfrom Feb 15, 2023
Merged
Do not mark already closed connection as to be reused#16121kokosing merged 1 commit intotrinodb:masterfrom
kokosing merged 1 commit intotrinodb:masterfrom
Conversation
wendigo
force-pushed
the
serafin/fix-reusable-connection-v2
branch
from
d362c4c to
8bbb88c
Compare
kokosing
approved these changes
Feb 15, 2023
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/ReusableConnectionFactory.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/TestReusableConnectionFactory.java
Outdated
Show resolved
Hide resolved
It can happen that the connection will be closed during the query execution, either by the JDBC driver or the connection pooling manager. When connection is closed, it shouldn't be available for reuse by the next getConnection caller.
wendigo
force-pushed
the
serafin/fix-reusable-connection-v2
branch
from
8bbb88c to
87bd5c2
Compare
ssheikin
approved these changes
Feb 15, 2023
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/TestReusableConnectionFactory.java
Show resolved
Hide resolved
kokosing
approved these changes
Feb 15, 2023
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can happen that the connection will be closed during the query execution, either by the JDBC driver or the connection pooling manager. When connection is closed, it shouldn't be available for reuse by the next getConnection caller.
Replaces #16115