Apply hive.max-partitions-for-eager-load after applying predicate #16113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raunaqmorarka
approved these changes
Feb 15, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HivePartitionManager.java
Outdated
Show resolved
Hide resolved
arhimondr
force-pushed
the
try-load-partitions
branch
from
f0bfed8 to
722b801
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
hive.max-partitions-for-eager-loadis needed to avoid allocating too manyHivePartitionobjects that could lead to an OOM on coordinator. This change ensures the limit is applied after the partition filter is applied and not before.Additional context and related issues
#16111
#14225
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(X) Release notes are required, with the following suggested text: