Retry dropping delta tables registered on AWS Glue#16092
Merged
ebyhr merged 3 commits intotrinodb:masterfrom Feb 21, 2023
Merged
Retry dropping delta tables registered on AWS Glue#16092ebyhr merged 3 commits intotrinodb:masterfrom
ebyhr merged 3 commits intotrinodb:masterfrom
Conversation
findinpath
added
the
no-release-notes
alexjo2144
reviewed
Feb 13, 2023
Member
alexjo2144
left a comment
alexjo2144
left a comment
There was a problem hiding this comment.
This is fine, but I think we could make a real code change instead of just a test change, retry drop table on Glue concurrent modification exceptions.
Usually it's not safe to retry unless you look at the changes from the other modification and reconcile them, but we're just dropping the table anyway so there shouldn't be anything to reconcile.
...no-product-tests/src/main/java/io/trino/tests/product/deltalake/util/DeltaLakeTestUtils.java
Outdated
Show resolved
Hide resolved
Member
|
/test-with-secrets sha=cfb2e40e654abc6b033cb6e4b3cfad8015e924a2 |
ebyhr
previously requested changes
Feb 13, 2023
...sts/src/main/java/io/trino/tests/product/deltalake/TestDeltaLakeAlterTableCompatibility.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/delta-databricks-retry-drop-table
branch
2 times, most recently
from
28fd876 to
5bc9a54
Compare
findinpath
commented
Feb 14, 2023
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/glue/TrinoGlueCatalog.java
Outdated
Show resolved
Hide resolved
alexjo2144
reviewed
Feb 14, 2023
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/glue/TrinoGlueCatalog.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/delta-databricks-retry-drop-table
branch
2 times, most recently
from
1f210b2 to
e61de80
Compare
alexjo2144
reviewed
Feb 15, 2023
Member
There was a problem hiding this comment.
Usually you'd just say .handle(ConcurrentModificationException.class), unless the exception is wrapped in something else?
Contributor
Author
There was a problem hiding this comment.
it is wrapped by a TrinoException
ebyhr
reviewed
Feb 15, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveMetastore.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveMetastore.java
Outdated
Show resolved
Hide resolved
...no-product-tests/src/main/java/io/trino/tests/product/deltalake/util/DeltaLakeTestUtils.java
Outdated
Show resolved
Hide resolved
...trino/plugin/deltalake/metastore/glue/TestDeltaLakeConcurrentModificationsGlueMetastore.java
Outdated
Show resolved
Hide resolved
...trino/plugin/deltalake/metastore/glue/TestDeltaLakeConcurrentModificationsGlueMetastore.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/delta-databricks-retry-drop-table
branch
3 times, most recently
from
8f34d2d to
32f2dbd
Compare
findinpath
added
release-notes
and removed
no-release-notes
findinpath
force-pushed
the
findinpath/delta-databricks-retry-drop-table
branch
from
dfc7d59 to
1237526
Compare
ebyhr
reviewed
Feb 21, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveMetastore.java
Outdated
Show resolved
Hide resolved
.../trino/plugin/deltalake/metastore/glue/TestDeltaLakeConcurrentModificationGlueMetastore.java
Outdated
Show resolved
Hide resolved
.../trino/plugin/deltalake/metastore/glue/TestDeltaLakeConcurrentModificationGlueMetastore.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueClientUtil.java
Outdated
Show resolved
Hide resolved
...no-product-tests/src/main/java/io/trino/tests/product/deltalake/util/DeltaLakeTestUtils.java
Outdated
Show resolved
Hide resolved
.../trino/plugin/deltalake/metastore/glue/TestDeltaLakeConcurrentModificationGlueMetastore.java
Outdated
Show resolved
Hide resolved
.../trino/plugin/deltalake/metastore/glue/TestDeltaLakeConcurrentModificationGlueMetastore.java
Outdated
Show resolved
Hide resolved
findinpath
force-pushed
the
findinpath/delta-databricks-retry-drop-table
branch
from
1237526 to
9e2d9d3
Compare
Contributor
Author
|
Rebasing on |
findinpath
force-pushed
the
findinpath/delta-databricks-retry-drop-table
branch
from
9e2d9d3 to
220b529
Compare
Retry the query dropping the AWS Glue table, in the unlikely situation that another query engine may be calling asynchronously in the background an update operation on the table.
findinpath
force-pushed
the
findinpath/delta-databricks-retry-drop-table
branch
from
220b529 to
2cced9b
Compare
Retry the query dropping the delta table on the Databricks cluster, in the unlikely situation that the Databricks cluster may be calling asynchronously in the background an update operation on the table.
findinpath
force-pushed
the
findinpath/delta-databricks-retry-drop-table
branch
from
2cced9b to
58ae39e
Compare
Contributor
Author
|
@ebyhr I have addressed the comments. Could you please trigger a new round of running the build with secrets? |
Member
|
/test-with-secrets sha=58ae39e511e35fa39dde6c78bea78b513d253f3b |
ebyhr
approved these changes
Feb 21, 2023
Member
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4230697367 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Retry dropping the delta table, in the unlikely situation that the Databricks cluster may be calling
asynchronously in the background
glue:UpdateTable(e.g.: update table schema) on AWS Glue.Additional context and related issues
Fixes #13199
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: