Merged
Conversation
ebyhr
force-pushed
the
ebi/core-filter-information-schema
branch
2 times, most recently
from
9e5f500 to
26da64e
Compare
ebyhr
force-pushed
the
ebi/core-filter-information-schema
branch
from
26da64e to
7df9deb
Compare
Member
Author
ebyhr
force-pushed
the
ebi/core-filter-information-schema
branch
from
7df9deb to
1c9ec05
Compare
findinpath
reviewed
Feb 17, 2023
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/glue/TrinoGlueCatalog.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/core-filter-information-schema
branch
2 times, most recently
from
4784c9a to
6db2f57
Compare
Member
Author
|
|
core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/core-filter-information-schema
branch
2 times, most recently
from
0b398f9 to
b8c7c1c
Compare
ebyhr
force-pushed
the
ebi/core-filter-information-schema
branch
from
b8c7c1c to
84887e4
Compare
github-actions
bot
added
bigquery
findepi
approved these changes
Mar 7, 2023
Member
There was a problem hiding this comment.
return schemaName.isPresent() && ...
so that the other method doesn't have to have @Nullable
Member
There was a problem hiding this comment.
isHiveSystemSchema("information_schema") should still return true, because "information_schema" is indeed a Hive system schema.
we should reword the comment though
ebyhr
force-pushed
the
ebi/core-filter-information-schema
branch
from
84887e4 to
88e66a2
Compare
ebyhr
force-pushed
the
ebi/core-filter-information-schema
branch
from
88e66a2 to
ff8876b
Compare
Member
Author
|
CI hit #16406 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1559
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.