Use identifiable exit code for application configuration errors#16049
Use identifiable exit code for application configuration errors#16049electrum merged 1 commit intotrinodb:masterfrom
Conversation
Configuration errors are always fatal and non-recoverable, so it helps to have a unique exit code.
|
Just as a friendly heads up, we generally skip release notes for improved error messaging because it's self-documenting when users encounter the errors. |
|
@colebow thanks for weighing in. In this particular case, we might want a release note since the behavior of the process is changing in that it can return a different code now. I wouldn't say that is self-documenting since there isn't really a formal standard definition for return codes. |
|
My point is more that users don't need to know about this change to benefit from it - when they bump into the new error code for the first time, they'll see the change organically. And if and only if they encounter the new error code themselves, this change won't impact how they use Trino. If we want to document what error codes mean, then that should be via actual documentation, as searching through old release notes isn't a preferred way to find or track down information. |
|
I see, btw we are superceding this PR with #16133 |
Not really true. Anyone who wrote their own systemd unit or have configured stop hooks on k8s needs to know the change otherwise their hooks and units won't work as expected. |
Description
Configuration errors are always fatal and non-recoverable, so it helps to have a unique exit code.
Additional context and related issues
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: