Ignore Hive system schema when listing views/materialized views#16047
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Feb 13, 2023
Merged
Conversation
fa55deb to
3af7138
Compare
Member
|
/test-with-secrets sha=3af71387dd3c0699ed56490e6a4529a1b495e4dc |
ebyhr
approved these changes
Feb 10, 2023
Contributor
Author
|
Unrelated failure on |
|
The CI workflow run with tests that require additional secrets finished as failure: https://github.com/trinodb/trino/actions/runs/4140970565 |
Member
|
@findinpath are those failures related to a change: https://github.com/trinodb/trino/actions/runs/4140970565 |
losipiuk
reviewed
Feb 12, 2023
Member
losipiuk
left a comment
There was a problem hiding this comment.
LGTM, but test-with-secrets failed. PTAL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the Iceberg connector when trying to see the tables from within information_schema schema while working with AWS Glue metastore:
The following exception occurs:
Solution
Same as on the
TrinoHiveCatalogmake use of an utility method to ignore Hive system schemas while listing the views/materialized views:trino/plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/hms/TrinoHiveCatalog.java
Line 464 in 49e4c06
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: