Skip to content

Pin protoc-jar-maven-plugin version#16043

Merged
findepi merged 1 commit intotrinodb:masterfrom
findepi:findepi/pin-protoc-jar-maven-plugin-version-f167ba
Feb 9, 2023
Merged

Pin protoc-jar-maven-plugin version#16043
findepi merged 1 commit intotrinodb:masterfrom
findepi:findepi/pin-protoc-jar-maven-plugin-version-f167ba

Conversation

@findepi
Copy link
Copy Markdown
Member

@findepi findepi commented Feb 9, 2023

Necessary for the build to be reproducible.

Necessary for the build to be reproducible.
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Feb 9, 2023

@nineinchnick @Praveen2112
how to find such places automatically?

i found this because mvnd was spitting out a warning on me, but generally this should be automated

Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@findepi
Copy link
Copy Markdown
Member Author

findepi commented Feb 9, 2023

Maybe we could use https://maven.apache.org/enforcer/enforcer-rules/requirePluginVersions.html ?

@findepi findepi merged commit ded7d53 into trinodb:master Feb 9, 2023
@findepi findepi deleted the findepi/pin-protoc-jar-maven-plugin-version-f167ba branch February 9, 2023 20:01
@findepi
Copy link
Copy Markdown
Member Author

findepi commented Feb 9, 2023

Maybe we could use https://maven.apache.org/enforcer/enforcer-rules/requirePluginVersions.html ?

this is looking for a volunteer

@github-actions github-actions bot added this to the 407 milestone Feb 10, 2023
@kokosing
Copy link
Copy Markdown
Member

this is looking for a volunteer

@ksobolew If you need a brake, you may want to take a look here.

@ksobolew
Copy link
Copy Markdown
Contributor

Maybe we could use https://maven.apache.org/enforcer/enforcer-rules/requirePluginVersions.html ?

this is looking for a volunteer

Easy peasy: airlift/airbase#340

@colebow colebow added the no-release-notes This pull request does not require release notes entry label Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed no-release-notes This pull request does not require release notes entry

Development

Successfully merging this pull request may close these issues.

6 participants