Optimize table function source#16010
Merged
kasiafi merged 2 commits intotrinodb:masterfrom Feb 9, 2023
Merged
Conversation
kasiafi
force-pushed
the
452TFRewriteEarly
branch
from
5661728 to
9999b5a
Compare
losipiuk
approved these changes
Feb 8, 2023
kasiafi
force-pushed
the
452TFRewriteEarly
branch
from
9999b5a to
54bc454
Compare
Do the rewrite from TableFunctionNode to TableFunctionProcessorNode earlier so that node pruning rules can be applied. Also, change the pushdown rule for table functions (RewriteTableFunctionToTableScan) to take the rewritten node. This is a step towards removing dependencies between optimizer rules.
kasiafi
force-pushed
the
452TFRewriteEarly
branch
from
54bc454 to
1ee7785
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an optimization. Currently it has no impact on users because table functions with table arguments are not yet supported.
We should add release notes only if this goes in after #15575