Add S3 connection ttl configuration to reduce http server exception#16007
Conversation
10610a2 to
497966e
Compare
|
Hi @sopel39 @alexjo2144 , can you please take a look when you have time, thanks~ |
|
@findepi please take over this one |
plugin/trino-hive/src/main/java/io/trino/plugin/hive/s3/HiveS3Config.java
Outdated
Show resolved
Hide resolved
|
@hackeryang can you please fix the build errors? |
497966e to
0c08967
Compare
@findepi Sure, i have fixed the build error, sorry for the capitalization mistake. Please review again when you have time, thank you~ |
|
Hello @findinpath , can you please cc when you have time, thank you |
0610143 to
cc0a718
Compare
plugin/trino-hive/src/main/java/io/trino/plugin/hive/s3/TrinoS3ConfigurationInitializer.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/s3/HiveS3Config.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/s3/HiveS3Config.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/s3select/TrinoS3ClientFactory.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/s3/HiveS3Config.java
Outdated
Show resolved
Hide resolved
9d3d564 to
d2140f6
Compare
plugin/trino-hive/src/main/java/io/trino/plugin/hive/s3select/TrinoS3ClientFactory.java
Outdated
Show resolved
Hide resolved
d2140f6 to
f09eabd
Compare
|
@losipiuk CPTAL ? |
f09eabd to
36c68b7
Compare
plugin/trino-hive/src/main/java/io/trino/plugin/hive/s3/HiveS3Config.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/s3/TrinoS3FileSystem.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/s3/TrinoS3FileSystem.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/s3/HiveS3Config.java
Outdated
Show resolved
Hide resolved
36c68b7 to
7cc9140
Compare
plugin/trino-hive/src/main/java/io/trino/plugin/hive/s3/TrinoS3ConfigurationInitializer.java
Outdated
Show resolved
Hide resolved
When a certain HTTP connection has been idle for a period of time, S3 will close the connection, but the SDK later tries to reuse the connection, then the client unable to execute HTTP request.
7cc9140 to
1db4892
Compare
we've had reports of this coming through the S3A connector and as well as adding a TTL, I'm thinking of classifying the the "no response" exception as a connectivity failure which we can treat as idempotent and retry on, always. |
Hello, good question~ |
Description
Add Amazon S3 connection ttl configuration to reduce http server errors in high load scenarios.
Additional context and related issues
Fixes #16005
Release notes
( ) This is not user-visible or docs only and no release notes are required.
(x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: