Skip to content

Fix flakiness from random input in TestParquetReaderMemoryUsage#16001

Merged
raunaqmorarka merged 1 commit intotrinodb:masterfrom
raunaqmorarka:fix-flaky
Feb 7, 2023
Merged

Fix flakiness from random input in TestParquetReaderMemoryUsage#16001
raunaqmorarka merged 1 commit intotrinodb:masterfrom
raunaqmorarka:fix-flaky

Conversation

@raunaqmorarka
Copy link
Copy Markdown
Member

@raunaqmorarka raunaqmorarka commented Feb 7, 2023

Description

Test can sometimes fail due to random input

io.trino.parquet.reader.TestParquetReaderMemoryUsage.testColumnReaderMemoryUsage  Time elapsed: 0.283 s  <<< FAILURE!
2023-02-06T20:14:38.2933047Z java.lang.AssertionError: 
2023-02-06T20:14:38.2933574Z 
2023-02-06T20:14:38.2933892Z Expecting value to be false but was true
2023-02-06T20:14:38.2934661Z 	at io.trino.parquet.reader.TestParquetReaderMemoryUsage.lambda$testColumnReaderMemoryUsage$0(TestParquetReaderMemoryUsage.java:75)

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Feb 7, 2023
@raunaqmorarka raunaqmorarka requested a review from sopel39 February 7, 2023 05:39
@raunaqmorarka raunaqmorarka merged commit b2266a2 into trinodb:master Feb 7, 2023
@raunaqmorarka raunaqmorarka deleted the fix-flaky branch February 7, 2023 11:20
@github-actions github-actions bot added this to the 407 milestone Feb 7, 2023
@colebow colebow mentioned this pull request Feb 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sopel39 sopel39 sopel39 approved these changes

Assignees

No one assigned

Labels

cla-signed

Milestone

407

Development

Successfully merging this pull request may close these issues.

2 participants

@raunaqmorarka @sopel39