Remove old expired kerberos tickets before relogging in#15997
Remove old expired kerberos tickets before relogging in#15997grantatspothero wants to merge 1 commit intotrinodb:masterfrom
Conversation
grantatspothero
changed the title
findepi
requested review from
anusudarsan,
arhimondr,
electrum,
kokosing and
wendigo
grantatspothero
force-pushed
the
gn/fixKerberosAuthKudu
branch
from
2a7e59b to
f4c7c0f
Compare
...plugin-toolkit/src/main/java/io/trino/plugin/base/authentication/KerberosAuthentication.java
Outdated
Show resolved
Hide resolved
|
#14373 got merged, please rebase |
grantatspothero
force-pushed
the
gn/fixKerberosAuthKudu
branch
from
f4c7c0f to
6e41e1c
Compare
|
@Praveen2112 @findepi @anusudarsan mind taking another look? Stress tests are green. |
|
@grantatspothero Can you please reword the commit |
grantatspothero
force-pushed
the
gn/fixKerberosAuthKudu
branch
from
5272392 to
9510fba
Compare
Was away on vacation 🌴, just fixed @Praveen2112 |
|
@Praveen2112 can you take another look? |
Praveen2112
left a comment
Praveen2112
left a comment
There was a problem hiding this comment.
LGTM. Can we reword the commit message to Remove old expired kerberos tickets before relogging in - as the fix is not only for Kudu and even for other connectors.
grantatspothero
force-pushed
the
gn/fixKerberosAuthKudu
branch
from
9510fba to
68db1e2
Compare
|
@Praveen2112 fixed. |
grantatspothero
changed the title
Praveen2112
changed the title
|
@Praveen2112 some unrelated tests flaked, it looks like I do not have permission to rerun just the failed modules. Can you do that? |
|
CI hit: #16013 |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
👋 @grantatspothero - this PR has become inactive. We hope you are still interested in working on it. Please let us know, and we can try to get reviewers to help with that. We're working on closing out old and inactive PRs, so if you're too busy or this has too many merge conflicts to be worth picking back up, we'll be making another pass to close it out in a few weeks. |
|
This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua |
|
Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time. |
6 participants
Description
This ensures old Kerberos tickets are removed before logging in again.
Approach is similar to this PR: #14373
but instead uses the
LoginContext#logoutmethod, which internally does similar logic tosubject.getPrivateCredentials().clear()Additional context and related issues
Stress test PR is here: https://github.com/trinodb/trino/pull/16018/files
Fixes: #14372
Fixes: #14441
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: