Move parameterizing enums to the top of enclosing class #15985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That makes it easier to understand how the class is parameterized. Consistent with code style in `LogicalExpression`. We could also choose to place such enums at the bottom (not my preference). In any case, they should not be somewhere in the middle, mixed between instance methods.
findepi
added
the
no-release-notes
raunaqmorarka
approved these changes
Feb 6, 2023
Praveen2112
approved these changes
Feb 6, 2023
Member
Praveen2112
left a comment
Praveen2112
left a comment
There was a problem hiding this comment.
Can we also mention the same here https://github.com/trinodb/trino/blob/master/.github/DEVELOPMENT.md
ebyhr
approved these changes
Feb 6, 2023
Member
Author
findepi
deleted the
findepi/move-parameterizing-enums-to-the-top-of-enclosing-class-16b223
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That makes it easier to understand how the class is parameterized. Consistent with code style in
LogicalExpression.We could also choose to place such enums at the bottom (not my preference). In any case, they should not be somewhere in the middle, mixed between instance methods.
cc @trinodb/maintainers for code style related