Skip to content

Fix log messages which are not format strings #15962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raunaqmorarka merged 1 commit into from
Feb 10, 2023
Merged

Fix log messages which are not format strings #15962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/trino-main/src/main/java/io/trino/server/security/oauth2/NimbusOAuth2Client.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ private Optional<JWTClaimsSet> queryUserInfo(String accessToken)
try {
UserInfoResponse response = httpClient.execute(new UserInfoRequest(userinfoUrl.get(), new BearerAccessToken(accessToken)), UserInfoResponse::parse);
if (!response.indicatesSuccess()) {
LOG.error("Received bad response from userinfo endpoint: " + response.toErrorResponse().getErrorObject());
LOG.error("Received bad response from userinfo endpoint: %s", response.toErrorResponse().getErrorObject());
return Optional.empty();
}
return Optional.of(response.toSuccessResponse().getUserInfo().toJWTClaimsSet());
Expand Down
2 changes: 1 addition & 1 deletion plugin/trino-hive/src/main/java/io/trino/plugin/hive/s3/TrinoS3FileSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1134,7 +1134,7 @@ private AWSCredentialsProvider createAwsCredentialsProvider(URI uri, Configurati
region = regionProviderChain.getRegion();
}
catch (SdkClientException ex) {
log.warn("Falling back to default AWS region " + US_EAST_1);
log.warn("Falling back to default AWS region %s", US_EAST_1);
region = US_EAST_1.getName();
}
}
Expand Down
2 changes: 1 addition & 1 deletion plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1310,7 +1310,7 @@ public void executeRemoveOrphanFiles(ConnectorSession session, IcebergTableExecu
IcebergSessionProperties.REMOVE_ORPHAN_FILES_MIN_RETENTION);

if (table.currentSnapshot() == null) {
log.debug("Skipping remove_orphan_files procedure for empty table " + table);
log.debug("Skipping remove_orphan_files procedure for empty table %s", table);
return;
}

Expand Down
2 changes: 1 addition & 1 deletion plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/catalog/BaseTrinoCatalogTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ public void testView()
catalog.dropNamespace(SESSION, namespace);
}
catch (Exception e) {
LOG.warn("Failed to clean up namespace: " + namespace);
LOG.warn("Failed to clean up namespace: %s", namespace);
}
}
}
Expand Down