Migrate some of PT environment to Multinode #15960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nineinchnick
approved these changes
Feb 3, 2023
Praveen2112
force-pushed
the
praveen/pt_cleanup
branch
from
451e156 to
ed298a9
Compare
kokosing
approved these changes
Feb 4, 2023
Member
There was a problem hiding this comment.
Please take a look at product tests README.md if there are no references to this env.
Member
|
Thanks! |
Praveen2112
force-pushed
the
praveen/pt_cleanup
branch
from
ed298a9 to
08ef85a
Compare
ebyhr
approved these changes
Feb 6, 2023
Member
There was a problem hiding this comment.
Could you remove "singlenode" from trino-product-tests/README.md?
Member
Author
There was a problem hiding this comment.
Thanks for pointing this. Have updated the README.md
We should use a multinode environment to mimic production like use case.
Praveen2112
force-pushed
the
praveen/pt_cleanup
branch
from
08ef85a to
5f6d26e
Compare
Praveen2112
force-pushed
the
praveen/pt_cleanup
branch
from
5f6d26e to
995e15b
Compare
Praveen2112
commented
Feb 8, 2023
...no-product-tests/src/main/java/io/trino/tests/product/mysql/TestJdbcDynamicFilteringJmx.java
Show resolved
Hide resolved
Member
|
|
Member
Author
|
Shouldn't we use |
Member
|
for local dev purposes it's just wasteful and makes putting breakpoint harder |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Usage of
Standardenvironment is deprecated as it doesn't mimic the production usage, still some of our PT environment use them. This PR migrates a few easy environment. We would migrate them in a phased manner.Release notes
(x) This is not user-visible or docs only and no release notes are required.