Fix verify() call in RcFileReader #15936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `in` parameter recently changed type from `SliceInput` to `DataSeekableInputStream`, the latter of which does not implement `toString`. Error Prone complains with `ObjectToString` because of that. Note that this only happens with trinodb#14933 merged, because otherwise the `verify` method is not a `@FormatMethod` and Error Prone can't verify correctness of its invocations. Passing `location` instead of `in` as the format string arguments is correct, because the stream is derived from a file at the location named by `location`.
ksobolew
force-pushed
the
kudi/fix-verify-call
branch
from
73320a1 to
fa5e7bf
Compare
kokosing
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
inparameter recently changed type fromSliceInputtoDataSeekableInputStream, the latter of which does not implementtoString. Error Prone complains withObjectToStringbecause of that.Note that this only happens with #14933 merged, because otherwise the
verifymethod is not a@FormatMethodand Error Prone can't verify correctness of its invocations.Passing
locationinstead ofinas the format string arguments is correct, because the stream is derived from a file at the location named bylocation.Additional context and related issues
It's kind of a shameless plug to promote #14933, which got stuck in reviews for some reason.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: