Use UserNameProvider for ThriftMetastore #15935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praveen2112
requested review from
findepi,
findinpath,
kokosing,
phd3 and
skrzypo987
skrzypo987
approved these changes
Feb 2, 2023
Member
skrzypo987
left a comment
skrzypo987
left a comment
There was a problem hiding this comment.
Is this a preparation for something bigger?
Member
There was a problem hiding this comment.
This can be a singleton defined in the interface itself:
public static final SIMPLE_USER_NAME_PROVIDER = identity -> identity.getUser();
and you can bound it to instance in guice modules
kokosing
reviewed
Feb 2, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/UserNameProvider.java
Outdated
Show resolved
Hide resolved
...hive/src/main/java/io/trino/plugin/hive/metastore/thrift/UgiBasedMetastoreClientFactory.java
Outdated
Show resolved
Hide resolved
...src/main/java/io/trino/plugin/hive/metastore/thrift/TokenFetchingMetastoreClientFactory.java
Outdated
Show resolved
Hide resolved
...in/trino-hive/src/main/java/io/trino/plugin/hive/metastore/thrift/ThriftMetastoreModule.java
Outdated
Show resolved
Hide resolved
Praveen2112
force-pushed
the
praveen/hive_user_name_provider
branch
from
9f3d398 to
c8aaaff
Compare
Praveen2112
changed the title
Praveen2112
force-pushed
the
praveen/hive_user_name_provider
branch
from
c8aaaff to
ae294a0
Compare
Member
Author
|
@kokosing , @skrzypo987 AC |
Member
|
|
kokosing
approved these changes
Feb 2, 2023
Praveen2112
force-pushed
the
praveen/hive_user_name_provider
branch
from
ae294a0 to
026a3ae
Compare
phd3
approved these changes
Feb 2, 2023
Praveen2112
force-pushed
the
praveen/hive_user_name_provider
branch
from
026a3ae to
b78172a
Compare
Praveen2112
force-pushed
the
praveen/hive_user_name_provider
branch
from
b78172a to
a830d42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides a small decoupling between
ThriftMetastoreClientandConnectorIdentity.As of now only
Thriftmetastore supports impersonation (which will be based onConnectorIdentity) so has moved it closer tothriftpackage - in future we can extend to other metastore if required.Release notes
(x) This is not user-visible or docs only and no release notes are required.