Put varying label first in check-commit matrix#15926
Closed
findepi wants to merge 2 commits intotrinodb:masterfrom
Closed
Put varying label first in check-commit matrix#15926findepi wants to merge 2 commits intotrinodb:masterfrom
findepi wants to merge 2 commits intotrinodb:masterfrom
Conversation
Following up to c350590, further improves GitHub Actions UI, but moving the constant part, the base branch name, off of view.
findepi
added
no-release-notes
findepi
requested review from
MiguelWeezardo,
ebyhr,
hashhar and
nineinchnick
nineinchnick
approved these changes
Feb 1, 2023
| run: | | ||
| # The output from rev-list ends with a newline, so we have to filter out index -1 in jq since it's an empty string | ||
| JQ_PIPELINE='split("\n") | .[0:-1] | map({base_ref: "${{ github.event.pull_request.base.ref }}", commit: .}) | select(length > 0) | {include: .}' | ||
| JQ_PIPELINE='split("\n") | .[0:-1] | map({commit: ., base_ref: "${{ github.event.pull_request.base.ref }}"}) | select(length > 0) | {include: .}' |
Member
There was a problem hiding this comment.
As we discussed offline, you could remove base_ref: "${{ github.event.pull_request.base.ref }}" and reference it directly instead of matrix.base_ref later.
Member
Author
There was a problem hiding this comment.
that would make my PR obsolete.
@nineinchnick do you want to send a PR with such change?
(be sure to include some empty commit, to exercise this within the PR)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up to c350590, further
improves GitHub Actions UI, but moving the constant part, the base
branch name, off of view.