Skip to content

Remove unused constants and methods from RaptorColumnHandle #15922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Feb 2, 2023
Merged

Remove unused constants and methods from RaptorColumnHandle #15922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions ...n/trino-raptor-legacy/src/main/java/io/trino/plugin/raptor/legacy/RaptorColumnHandle.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
import io.trino.spi.connector.ColumnHandle;
import io.trino.spi.type.BigintType;
import io.trino.spi.type.Type;

import java.util.Objects;
Expand All @@ -34,8 +33,6 @@ public final class RaptorColumnHandle
{
// Generated rowId column for updates
private static final long SHARD_ROW_ID_COLUMN_ID = -1;
private static final String SHARD_ROW_ID_COLUMN_NAME = "$shard_row_id";
private static final BigintType SHARD_ROW_ID_COLUMN_TYPE = BIGINT;

public static final long SHARD_UUID_COLUMN_ID = -2;
public static final String SHARD_UUID_COLUMN_NAME = "$shard_uuid";
Expand Down Expand Up @@ -109,11 +106,6 @@ public int hashCode()
return Objects.hash(columnId);
}

public boolean isShardRowId()
{
return isShardRowIdColumn(columnId);
}

public boolean isShardUuid()
{
return isShardUuidColumn(columnId);
Expand All @@ -129,11 +121,6 @@ public static boolean isShardRowIdColumn(long columnId)
return columnId == SHARD_ROW_ID_COLUMN_ID;
}

public static RaptorColumnHandle shardRowIdHandle()
{
return new RaptorColumnHandle(SHARD_ROW_ID_COLUMN_NAME, SHARD_ROW_ID_COLUMN_ID, SHARD_ROW_ID_COLUMN_TYPE);
}

public static boolean isShardUuidColumn(long columnId)
{
return columnId == SHARD_UUID_COLUMN_ID;
Expand Down