Fix NPE when Glue table has no type#15909
Merged
findepi merged 1 commit intotrinodb:masterfrom Feb 1, 2023
Merged
Conversation
sopel39
approved these changes
Jan 31, 2023
...o-hive/src/main/java/io/trino/plugin/hive/metastore/glue/converter/GlueToTrinoConverter.java
Outdated
Show resolved
Hide resolved
Member
Author
|
CI known FTE failures |
findepi
force-pushed
the
findepi/fix-npe-when-glue-table-has-no-type-6f8492
branch
from
7a53613 to
230576e
Compare
alexjo2144
approved these changes
Jan 31, 2023
findinpath
reviewed
Jan 31, 2023
...o-hive/src/main/java/io/trino/plugin/hive/metastore/glue/converter/GlueToTrinoConverter.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/metastore/glue/GlueHiveMetastore.java
Outdated
Show resolved
Hide resolved
findinpath
approved these changes
Jan 31, 2023
electrum
reviewed
Jan 31, 2023
.mvn/modernizer/violations.xml
Outdated
ebyhr
approved these changes
Feb 1, 2023
Member
Author
`Glue.getTableType` is nullable.
findepi
force-pushed
the
findepi/fix-npe-when-glue-table-has-no-type-6f8492
branch
from
230576e to
8e0261d
Compare
Closed
findepi
deleted the
findepi/fix-npe-when-glue-table-has-no-type-6f8492
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Glue.getTableTypeis nullable.