Avoid saving cache in the build-test-matrix CI job #15896
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This job is not supposed to download all dependencies, so it should not be saving the local Maven repository in the GitHub Actions cache. Since it can run quick than other jobs that do a full build, it can generate an incomplete cache entry, preventing bigger cache entries from being saved.
findepi
approved these changes
Jan 30, 2023
Member
findepi
left a comment
findepi
left a comment
There was a problem hiding this comment.
@nineinchnick explained to me offline how it works. thanks Jan!
hashhar
approved these changes
Jan 30, 2023
Member
Author
|
Just a note, the v3 of We can refactor |
Member
|
@nineinchnick can you please do me a favor and check why the build isn't green? |
Member
Author
|
Both look like flaky tests: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This job is not supposed to download all dependencies, so it should not be saving the local Maven repository in the GitHub Actions cache. Since it can run quicker than other jobs that do a full build, it can generate an incomplete cache entry, preventing bigger cache entries from being saved.
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: