Obtain and refresh sink instance handle asynchronously#15870
Merged
losipiuk merged 5 commits intotrinodb:masterfrom Feb 1, 2023
Merged
Obtain and refresh sink instance handle asynchronously#15870losipiuk merged 5 commits intotrinodb:masterfrom
losipiuk merged 5 commits intotrinodb:masterfrom
Conversation
losipiuk
changed the title
losipiuk
force-pushed
the
lo/future-sink-instance-handle
branch
3 times, most recently
from
d5ba4a9 to
2721958
Compare
arhimondr
approved these changes
Jan 30, 2023
...-main/src/main/java/io/trino/execution/scheduler/EventDrivenFaultTolerantQueryScheduler.java
Outdated
Show resolved
Hide resolved
...-main/src/main/java/io/trino/execution/scheduler/EventDrivenFaultTolerantQueryScheduler.java
Outdated
Show resolved
Hide resolved
Contributor
|
The implementation looks reasonable, however there are test failures. There's nothing obvious I can see being wrong right away though. |
linzebing
approved these changes
Jan 30, 2023
core/trino-main/src/main/java/io/trino/operator/DeduplicatingDirectExchangeBuffer.java
Outdated
Show resolved
Hide resolved
Member
There was a problem hiding this comment.
Reason for timeout to be different from DeduplicatingDirectExchangeBuffer?
Member
Author
There was a problem hiding this comment.
This class will be gone. DOes not matter
losipiuk
force-pushed
the
lo/future-sink-instance-handle
branch
2 times, most recently
from
d0917c3 to
ef9a33a
Compare
losipiuk
force-pushed
the
lo/future-sink-instance-handle
branch
from
ef9a33a to
7530326
Compare
arhimondr
approved these changes
Jan 30, 2023
It is not always possible for exchange implementation to provide an immediate return for calls to: * `Exchange.instantiateSink `and * `Exchange.updateSinkInstanceHandle` depending on exchange implementation sometimes there needs to be a network the communication involved or another lengthy process. To allow for such exchange implementations and not block engine threads this PR changes SPI so the two methods listed above now return `CompletableFuture<ExchangeSinkInstanceHandle>`.
losipiuk
force-pushed
the
lo/future-sink-instance-handle
branch
from
7530326 to
45c51c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It is not always possible for exchange implementation to
provide an immediate return for calls to:
Exchange.instantiateSinkandExchange.updateSinkInstanceHandledepending on exchange implementation sometimes there needs to be a network
the communication involved or another lengthy process. To allow for such
exchange implementations and not block engine threads this PR changes
SPI so the two methods listed above now return
CompletableFuture<ExchangeSinkInstanceHandle>.Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: