Type constants for time with time zone consistent with other temporal parametric types
#15849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
findepi
added
the
no-release-notes
findepi
requested review from
ebyhr,
electrum,
jirassimok,
losipiuk,
martint and
raunaqmorarka
ebyhr
approved these changes
Jan 26, 2023
Similar to `TimeType` in 3d0af3b.
The unsupported types are handled at the end of the `toWriteMapping` method.
This isn't dissimilar to how we use constants in other temporal types.
findepi
force-pushed
the
findepi/timetz
branch
2 times, most recently
from
b3df3c0 to
1aaa211
Compare
raunaqmorarka
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.