Refactor materialized view tests #15844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method was not a necessary for subclasses to implement, because the base class can know the schema name directly. This also makes the code more consistent, as there already were some code pieces in the class which get schema name from session setup directly.
findepi
added
test
no-release-notes
findepi
requested review from
alexjo2144,
anjalinorwood,
ebyhr,
raunaqmorarka and
sopel39
raunaqmorarka
approved these changes
Jan 25, 2023
alexjo2144
approved these changes
Jan 25, 2023
ebyhr
approved these changes
Jan 26, 2023
Member
There was a problem hiding this comment.
Could you rename the class in trino-iceberg/pom.xml too?
Concrete test classes start with "Test" and typically do not end with "Test". `BaseConnectorTest` (BCT) and `BaseConnectorSmokeTest` (BCST) subclasses are noticeable exceptions.
- Avoid reassigning variable in test. Mutable variable asserted on is more error-prone than asserting directly without assigning to a variable. The latter approach is equally (if not more) readable, if formatted properly. - Update test queries to follow SQL code style.
findepi
force-pushed
the
findepi/improve-baseicebergmaterializedviewtest-code-style-2206dc
branch
from
61b5ddf to
647e60c
Compare
Member
Author
|
/test-with-secrets sha=647e60cc1181d3b78cf6a585f7e3be1bf54cf6cd |
findepi
deleted the
findepi/improve-baseicebergmaterializedviewtest-code-style-2206dc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #15842