Downscale base connector tests #15816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Could you confirm CI failures? |
SemionPar
force-pushed
the
semionpar/downscale-base-connector-tests
branch
3 times, most recently
from
bbae176 to
347cbd2
Compare
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
SemionPar
force-pushed
the
semionpar/downscale-base-connector-tests
branch
4 times, most recently
from
65ef90b to
afe551f
Compare
Member
|
@SemionPar can we mark this ready for review? |
SemionPar
force-pushed
the
semionpar/downscale-base-connector-tests
branch
2 times, most recently
from
6bc0d42 to
9ca9691
Compare
SemionPar
requested review from
raunaqmorarka
and removed request for
hashhar and
wendigo
raunaqmorarka
approved these changes
Feb 1, 2023
hashhar
approved these changes
Feb 2, 2023
Member
There was a problem hiding this comment.
where does 111_200 come from? the estimated join size was 83_400 AFAIK.
Contributor
Author
There was a problem hiding this comment.
That's what I would expect, too, after consistently decreasing data size 10x, but actually its 111200 (joinDataSize when I put the breakpoint in
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseAutomaticJoinPushdownTest.java
Outdated
Show resolved
Hide resolved
SemionPar
force-pushed
the
semionpar/downscale-base-connector-tests
branch
from
9d35e73 to
24d9588
Compare
Member
|
@hashhar who can merge this PR? looks like comments are addressed |
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseAutomaticJoinPushdownTest.java
Outdated
Show resolved
Hide resolved
Use smaller tables or smaller datasets in general, where appropriate. This should speed up tests for some connectors considerably.
SemionPar
force-pushed
the
semionpar/downscale-base-connector-tests
branch
from
24d9588 to
51d48fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use smaller tables or smaller data sets in general, where appropriate. This should speed up tests for some connectors considerably.
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: