Skip to content

Reorganize Hive connector and Hive security documentation#15637

Merged
electrum merged 1 commit intotrinodb:masterfrom
m57lyra:ab/object-storage-reorg-pr-1-of-11
Feb 28, 2023
Merged

Reorganize Hive connector and Hive security documentation#15637
electrum merged 1 commit intotrinodb:masterfrom
m57lyra:ab/object-storage-reorg-pr-1-of-11

Conversation

@m57lyra
Copy link
Copy Markdown
Contributor

@m57lyra m57lyra commented Jan 6, 2023

Description

This is one of 11 planned PRs to update object storage connector docs that modernize and organize object storage documentation. This first PR is a key reorganization that brings the Hive connector and Hive security page organization and table formats inline with other newer connectors, and stages information for further organization.

There are no content changes except to address headers with no introductory sentence.

Additional context and related issues

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Jan 6, 2023
@github-actions github-actions bot added the docs label Jan 6, 2023
@m57lyra m57lyra requested a review from mosabua January 6, 2023 22:00
@m57lyra
Copy link
Copy Markdown
Contributor Author

m57lyra commented Jan 6, 2023

hive.rst, updated right-hand nav:

Screenshot 2023-01-27 at 1 55 16 PM

hive-security.rst, updated right-hand nav:

Screen Shot 2023-01-06 at 2 06 09 PM

@m57lyra m57lyra force-pushed the ab/object-storage-reorg-pr-1-of-11 branch 3 times, most recently from 57a774e to 4567ba4 Compare January 27, 2023 22:35
@findinpath findinpath requested a review from wendigo February 10, 2023 05:46
@findinpath
Copy link
Copy Markdown
Contributor

@m57lyra please split your changes in multiple commits.
In the current stage this PR feels like a big-bang change and it takes a lot of time to distinguish what content stays basically the same (but moved to a different location/section) and what actually changes.

@findinpath
Copy link
Copy Markdown
Contributor

Please resolve the conflicts with master.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wendigo CTAL at these changes?

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Feb 10, 2023

@findinpath @wendigo @ebyhr and anyone else reviewing .. I would ask you all to consider this PR as a temporary step into a very large refactor of the documentation for all object storage connectors. @m57lyra has created a great project plan and discussed it with myself, @claudiusli, @electrum, and others.

The individual PRs as you can see on this first one are already very large, but are currently only moving content around or updating formatting or grammar. No technical content is changed. It therefore is only one commit.

Ideally we get as many of these PRs through the merge queue as fast as possible so that we can get to the desired end state faster and then work on improving the actual content. If you want to get further details please contact @m57lyra or myself for a demo or detailed chat.

@m57lyra
Copy link
Copy Markdown
Contributor Author

m57lyra commented Feb 10, 2023

@m57lyra please split your changes in multiple commits.

In the current stage this PR feels like a big-bang change and it takes a lot of time to distinguish what content stays basically the same (but moved to a different location/section) and what actually changes.

There are no content changes other than to add an introductory sentence between headers where there was none.unfortunately doing multiple commits would appear nonsensical and without context, as moving one chunk leaves a hole and we'd be having the same conversation over and over about " but what about that empty spot, that doesn't make sense" with every commit.

This PR reorganizes things, there is no technical content touched.

Copy link
Copy Markdown
Member

@alexjo2144 alexjo2144 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nitpicky things but this looks like a huge improvement

@m57lyra m57lyra changed the title Hive connector and security pages reorganization Reorganize Hive connector and Hive security documentation Feb 14, 2023
@m57lyra m57lyra force-pushed the ab/object-storage-reorg-pr-1-of-11 branch from 4567ba4 to d494e95 Compare February 15, 2023 16:39
@m57lyra m57lyra requested a review from alexjo2144 February 15, 2023 16:39
@alexjo2144
Copy link
Copy Markdown
Member

@m57lyra just wanted to make sure you saw that the docs-check check is red.

@m57lyra
Copy link
Copy Markdown
Contributor Author

m57lyra commented Feb 23, 2023

@m57lyra just wanted to make sure you saw that the docs-check check is red.

Yup. It's all maven stuff.

@m57lyra m57lyra force-pushed the ab/object-storage-reorg-pr-1-of-11 branch from 53eaebb to 4f9dc94 Compare February 23, 2023 20:03
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive moving around with out content changes. Love it. Lets get this merged before or right after 408 ;-)

@m57lyra m57lyra force-pushed the ab/object-storage-reorg-pr-1-of-11 branch from 4f9dc94 to 68ac5eb Compare February 24, 2023 23:10
@m57lyra m57lyra requested a review from electrum February 24, 2023 23:15
@electrum electrum merged commit 27e6ff9 into trinodb:master Feb 28, 2023
@github-actions github-actions bot added this to the 409 milestone Feb 28, 2023
Trino does not support gathering table statistics for Hive transactional tables.
You need to use Hive to gather table statistics with ``ANALYZE TABLE COMPUTE STATISTICS`` after table creation.
* Trino does not support gathering table statistics for Hive transactional tables.
You must use Hive to gather table statistics with ``ANALYZE TABLE COMPUTE STATISTICS`` after table creation. No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hive used to require multiple analyze runs (ANALYZE TABLE COMPUTE STATISTIC and ANALYZE TABLE COMPUTE STATISTIC FOR COLUMNS). Maybe we don't need to document how to collect stats on Hive. Maybe we just let people check the Hive docs for that?

cc @m57lyra @ebyhr

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sent #16376

@m57lyra m57lyra deleted the ab/object-storage-reorg-pr-1-of-11 branch March 6, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

7 participants