Skip to content

Correct exception type when table exists while creating a view #15580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krvikash wants to merge 1 commit into from
Closed

Correct exception type when table exists while creating a view #15580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2605,7 +2605,7 @@ public void createView(ConnectorSession session, SchemaTableName viewName, Conne
Optional<Table> existing = metastore.getTable(viewName.getSchemaName(), viewName.getTableName());
if (existing.isPresent()) {
if (!replace || !isPrestoView(existing.get())) {
throw new ViewAlreadyExistsException(viewName);
Copy link
Copy Markdown
Contributor

@findinpath findinpath Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other uses of ViewAlreadyExistsException which may be probably replaced by TableAlreadyExistsException.

If you replace all of them, then probably ViewAlreadyExistsException may be removed.

cc @electrum

Copy link
Copy Markdown
Contributor Author

@krvikash krvikash Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ViewAlreadyExistsException is required for the case when a view already exists while creating a view.

This PR specially deals with when A table exists while creating a view.

Copy link
Copy Markdown
Contributor

@findinpath findinpath Jan 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the cases where currently ViewAlreadyExistsException we are doing previously metastore.getTable(..) calls.
I'm thinking that if the metastore calls for a "table", then TableAlreadyExistsException is appropriate.

throw new TableAlreadyExistsException(viewName);
}

metastore.replaceTable(viewName.getSchemaName(), viewName.getTableName(), table, principalPrivileges);
Expand Down
2 changes: 1 addition & 1 deletion plugin/trino-hive/src/main/java/io/trino/plugin/hive/TrinoViewHiveMetastore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ public void createView(ConnectorSession session, SchemaTableName schemaViewName,
Optional<io.trino.plugin.hive.metastore.Table> existing = metastore.getTable(schemaViewName.getSchemaName(), schemaViewName.getTableName());
if (existing.isPresent()) {
if (!replace || !isPrestoView(existing.get())) {
throw new ViewAlreadyExistsException(schemaViewName);
throw new TableAlreadyExistsException(schemaViewName);
}

metastore.replaceTable(schemaViewName.getSchemaName(), schemaViewName.getTableName(), table, principalPrivileges);
Expand Down
3 changes: 3 additions & 0 deletions plugin/trino-hive/src/test/java/io/trino/plugin/hive/AbstractTestHive.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3925,6 +3925,9 @@ private void verifyViewCreation(SchemaTableName temporaryCreateView)
doCreateView(temporaryCreateView, false);
fail("create existing should fail");
}
catch (TableAlreadyExistsException e) {
Copy link
Copy Markdown
Member

@findepi findepi Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shall we remove the catch (ViewAlreadyExistsExcept clause below?

assertEquals(e.getTableName(), temporaryCreateView);
}
catch (ViewAlreadyExistsException e) {
assertEquals(e.getViewName(), temporaryCreateView);
}
Expand Down
6 changes: 3 additions & 3 deletions ...in/trino-iceberg/src/main/java/io/trino/plugin/iceberg/catalog/glue/TrinoGlueCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import io.trino.filesystem.TrinoFileSystemFactory;
import io.trino.plugin.base.CatalogName;
import io.trino.plugin.hive.SchemaAlreadyExistsException;
import io.trino.plugin.hive.TableAlreadyExistsException;
import io.trino.plugin.hive.TrinoViewUtil;
import io.trino.plugin.hive.ViewAlreadyExistsException;
import io.trino.plugin.hive.metastore.glue.GlueMetastoreStats;
Expand Down Expand Up @@ -550,7 +551,7 @@ public void createView(ConnectorSession session, SchemaTableName schemaViewName,
Failsafe.with(new RetryPolicy<>()
.withMaxRetries(3)
.withDelay(Duration.ofMillis(100))
.abortIf(throwable -> !replace || throwable instanceof ViewAlreadyExistsException))
.abortIf(throwable -> !replace || throwable instanceof ViewAlreadyExistsException || throwable instanceof TableAlreadyExistsException))
.run(() -> doCreateView(session, schemaViewName, viewTableInput, replace));
}

Expand All @@ -559,8 +560,7 @@ private void doCreateView(ConnectorSession session, SchemaTableName schemaViewNa
Optional<com.amazonaws.services.glue.model.Table> existing = getTable(session, schemaViewName);
if (existing.isPresent()) {
if (!replace || !isPrestoView(firstNonNull(existing.get().getParameters(), ImmutableMap.of()))) {
// TODO: ViewAlreadyExists is misleading if the name is used by a table https://github.com/trinodb/trino/issues/10037
Copy link
Copy Markdown
Member

@findepi findepi Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10037

Copy link
Copy Markdown
Member

@findepi findepi Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this PR supposed to close that issue?

Copy link
Copy Markdown
Contributor Author

@krvikash krvikash Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Issue #10037 should have been closed by #10186.

This PR #15580 is follow-up TODO task for https://github.com/trinodb/trino/pull/11499/files#diff-0c09267905a13855768761575aee308f9a1773e6f3d59c6347de78fa8dbc1c02R422

Copy link
Copy Markdown
Member

@findepi findepi Jan 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Issue #10037 should have been closed by #10186.

the issue is currently open

throw new ViewAlreadyExistsException(schemaViewName);
throw new TableAlreadyExistsException(schemaViewName);
}

stats.getUpdateTable().call(() ->
Expand Down