Retrieve the table handle only when dealing with a system table#15568
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Mar 8, 2023
Merged
Conversation
Member
|
Why is this "DO NOT MERGE"? |
Contributor
Author
|
Yes, at the moment is not reviewable. I made a false supposition while writing it. |
571ea1d to
218b329
Compare
2325b82 to
f4000d4
Compare
Contributor
Author
|
CI Hit #5427 |
a55b4d0 to
746d0e8
Compare
746d0e8 to
6ea2487
Compare
findinpath
commented
Feb 28, 2023
Contributor
Author
|
@ebyhr CPTAL at this PR ? It is pretty similar to what has been done for the |
ebyhr
approved these changes
Mar 8, 2023
6ea2487 to
20e802a
Compare
Member
|
CI hit #15187 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a small usability improvement which aims to provide a more meaningful error message to the user in case that the user asks for an invalid metadata table corresponding to an existing Iceberg table.
Additional context and related issues
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: