Avoid reading data in parquet ChunkedInputStream constructor#15552
Merged
raunaqmorarka merged 3 commits intotrinodb:masterfrom Jan 3, 2023
Merged
Avoid reading data in parquet ChunkedInputStream constructor#15552raunaqmorarka merged 3 commits intotrinodb:masterfrom
raunaqmorarka merged 3 commits intotrinodb:masterfrom
Conversation
Avoids code duplication and makes the API easier to use
raunaqmorarka
force-pushed
the
fix-lazy-read
branch
from
64a672c to
ee5c3ce
Compare
lukasz-stec
approved these changes
Jan 2, 2023
lib/trino-parquet/src/main/java/io/trino/parquet/reader/ChunkedInputStream.java
Outdated
Show resolved
Hide resolved
Chunks should be read lazily to avoid reading data in case lazy loading of blocks can avoid reading a column due to a selective filter on a preceding column
raunaqmorarka
force-pushed
the
fix-lazy-read
branch
from
ee5c3ce to
0cc5c33
Compare
sopel39
approved these changes
Jan 3, 2023
|
|
||
| if (data == null) { | ||
| byte[] buffer = new byte[toIntExact(range.getLength())]; | ||
| readerMemoryUsage.setBytes(buffer.length); |
Member
There was a problem hiding this comment.
nit: in practice it doesn't matter since memory usage is propagated in ScanFilterOperator in a lazy way anyway
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Avoid reading data in parquet ChunkedInputStream constructor
Additional context and related issues
Fixes a perf regression in lazy reading of data from #15374
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: