Skip to content

Add test for DROP TABLE IF EXISTS statement with non-existing object #15464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 2 commits into from
Dec 22, 2022
Merged

Add test for DROP TABLE IF EXISTS statement with non-existing object #15464

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61543a2
Add test for DROP TABLE IF EXISTS statement with non-existing object
krvikash Dec 19, 2022
470843c
Rename test case in TestDropTableTask
krvikash Dec 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions core/trino-main/src/test/java/io/trino/execution/TestDropTableTask.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,25 @@ public void testDropNotExistingTable()
}

@Test
public void testDropNotExistingTableIfExists()
public void testDropTableIfExistsWithoutExistingCatalog()
{
QualifiedName tableName = QualifiedName.of("non_existing_catalog", "non_existing_schema", "not_existing_table");

getFutureValue(executeDropTable(tableName, true));
// no exception
}

@Test
public void testDropTableIfExistsWithoutExistingSchema()
{
QualifiedName tableName = QualifiedName.of(TEST_CATALOG_NAME, "non_existing_schema", "not_existing_table");

getFutureValue(executeDropTable(tableName, true));
// no exception
}

@Test
public void testDropTableIfExistsWithoutExistingTable()
{
QualifiedName tableName = qualifiedName("not_existing_table");

Expand All @@ -75,7 +93,7 @@ public void testDropTableOnView()
}

@Test
public void testDropTableOnViewIfExists()
public void testDropTableIfExistsOnView()
{
QualifiedName viewName = qualifiedName("existing_view");
metadata.createView(testSession, asQualifiedObjectName(viewName), someView(), false);
Expand All @@ -97,7 +115,7 @@ public void testDropTableOnMaterializedView()
}

@Test
public void testDropTableOnMaterializedViewIfExists()
public void testDropTableIfExistsOnMaterializedView()
{
QualifiedName viewName = qualifiedName("existing_materialized_view");
metadata.createMaterializedView(testSession, asQualifiedObjectName(viewName), someMaterializedView(), false, false);
Expand Down