Support protobuf build-in Value within c#15384
Closed
mx123 wants to merge 25 commits intotrinodb:masterfrom
Closed
Support protobuf build-in Value within c#15384mx123 wants to merge 25 commits intotrinodb:masterfrom
mx123 wants to merge 25 commits intotrinodb:masterfrom
Conversation
When refresh token is retrieved for UI, currently we were sending HTTP Status 303, assuming that all the request will just repeat the call on the Location header. When this works for GET/PUT verbs, it does not for non-idempotent ones like POST, as every js http client should do a GET on LOCATION after 303 on POST. Due to that I change it to 307, that should force every client to repeat exactly the same request, no matter the verb. Co-authored-by: s2lomon <s2lomon@gmail.com>
Actual work is done in `pageProjectWork.process()` call while `projection.project` only performs setup of projection. So both `expressionProfiler` and `metrics.recordProjectionTime` needed to be around that method.
Removes outdated comments and unnecessary methods in local exchange PartitioningExchanger since the operator is no longer implemented in a way that attempts to be thread-safe.
- Change ColumnHandle to BigQueryColumnHandle in BigQueryTableHandle - Extract buildColumnHandles in BigQueryClient
mx123
commented
Dec 13, 2022
Contributor
Author
There was a problem hiding this comment.
Json object convert is doing by very naive way to open discussion how to better implement it.
cc: @kokosing, @Praveen2112, @findepi
findepi
reviewed
Dec 13, 2022
Member
There was a problem hiding this comment.
I personally would prefer to IF on the source type ( whether it's https://developers.google.com/protocol-buffers/docs/reference/google.protobuf#value )
but i don't know Kafka connector conventions
Contributor
Author
There was a problem hiding this comment.
it initiates to recognise as Value object here . After that registry's schema parsed there are it has only defined type and some value encapsulated to DynamicMessage. To know what's the exact type passing it's need to be converted anyway by json formatter.
Kafka protobuf registry schema cannot be translated to plain Trino SQL structure in common cases when included data types use referencing to same objects recursively.
Message sending to Kafka thows NPE if proto file has `import` derective.
Kafka protobuf schema registry parsing falls to dead loop if has included references to the same object. It's need to abort the recursion loop with appropriated parsing error.
mx123
force-pushed
the
kafka_protobuf_buildin_value
branch
from
120cc43 to
9f93cfa
Compare
Contributor
Author
|
closed after offline discussion with @hashhar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Protobuf Google build-in com.google.protobuf.Value should be supported within Kafka Schema Registry.
Additional context and related issues
see Prevent Kafka protobuf schema registry message parsing dead loop recursion PR for details.