Ensure Parameters are in proper order for queries having WITH clause

[Praveen2112]

Fixes #1191

[martint]

This will produce an ordering based on traversal order. We need to:

1. Collect all the Parameter nodes
2. Sort them based on their lexical order (Parameter.getLocation())

[martint]

Instead of passing parameters and parameterPositionMap everywhere, why not compose them into a single mapping of parameter -> expression (i.e., Map<NodeRef<Parameter>, Expression>) in Analysis and pass that around?

[martint]

Instead of assembling these into a long, compare based on line first and then based on column number.

[martint]

There's already a class that does this: ParameterExtractor.

This could all be replaced with:

List<Parameter> parameters = getParameters(...).stream()
        .sorted(Comparator.comparing(
                parameter -> parameter.getLocation().get(),
                Comparator.comparing(NodeLocation::getLineNumber)
                        .thenComparing(NodeLocation::getColumnNumber)))
        .collect(Collectors.toList());

[martint]

The type of this should be Map<NodeRef<Parameter>, Integer>

[martint]

Make this a Map<NodeRef<Parameter>, Integer> and rename the variable to parameterOrdinals

[martint]

Can you add an end-to-end test that involves WITH to make sure parameters are being interpreted correctly?