Skip to content

Attempt to upload heap dump if tests failed #15181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hashhar merged 2 commits into from
Nov 25, 2022
+121 −41
Merged

Attempt to upload heap dump if tests failed #15181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1ea1827
Revert "Upload test results and reports as a composite action"
Nov 24, 2022
df43ba3
Attempt to upload heap dump if tests failed
Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 0 additions & 31 deletions .github/actions/upload/action.yml
View file
Open in desktop

This file was deleted.

131 changes: 121 additions & 10 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ env:
# This value should be greater than the time taken for the longest image pull.
TESTCONTAINERS_PULL_PAUSE_TIMEOUT: 600
TEST_REPORT_RETENTION_DAYS: 5
HEAP_DUMP_RETENTION_DAYS: 14
# used by actions/cache to retry the download after this time: https://github.com/actions/cache/blob/main/workarounds.md#cache-segment-restore-timeout
SEGMENT_DOWNLOAD_TIMEOUT_MINS: 5

Expand Down Expand Up @@ -153,6 +154,8 @@ jobs:
test-jdbc-compatibility:
runs-on: ubuntu-latest
timeout-minutes: 30
env:
SECRETS_PRESENT: ${{ secrets.SECRETS_PRESENT }}
steps:
- uses: actions/checkout@v3
with:
Expand All @@ -173,9 +176,35 @@ jobs:
if [ ! -f gib-impacted.log ] || grep -q testing/trino-test-jdbc-compatibility-old-server gib-impacted.log; then
$MAVEN test ${MAVEN_TEST} -pl :trino-test-jdbc-compatibility-old-server
fi
- uses: ./.github/actions/upload
- name: Upload test results
uses: actions/upload-artifact@v3
# Upload all test reports only on failure, because the artifacts are large
if: failure()
with:
name: result ${{ github.job }}
path: |
**/target/surefire-reports
**/target/checkstyle-*
- name: Upload test report
uses: actions/upload-artifact@v3
# Always upload the test report for the annotate.yml workflow,
# but only the single XML file to keep the artifact small
if: always()
with:
# Name prefix is checked in the `Annotate checks` workflow
name: test report ${{ github.job }}
path: |
**/surefire-reports/TEST-*.xml
retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
- name: Upload heap dump
uses: actions/upload-artifact@v3
if: failure() && env.SECRETS_PRESENT == '' && github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository
with:
test-report-retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
name: heap dump ${{ github.job }}
if-no-files-found: 'ignore'
path: |
**/*.hprof
retention-days: ${{ env.HEAP_DUMP_RETENTION_DAYS }}
- name: Clean local Maven repo
# Avoid creating a cache entry because this job doesn't download all dependencies
if: steps.cache.outputs.cache-hit != 'true'
Expand All @@ -190,6 +219,8 @@ jobs:
- config-hdp3
# TODO: config-apache-hive3
timeout-minutes: 60
env:
SECRETS_PRESENT: ${{ secrets.SECRETS_PRESENT }}
steps:
- uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -278,10 +309,35 @@ jobs:
run: |
source plugin/trino-hive-hadoop2/conf/hive-tests-${{ matrix.config }}.sh &&
plugin/trino-hive-hadoop2/bin/run_hive_alluxio_tests.sh
- uses: ./.github/actions/upload
- name: Upload test results
uses: actions/upload-artifact@v3
# Upload all test reports only on failure, because the artifacts are large
if: failure()
with:
name: result ${{ github.job }}
path: |
**/target/surefire-reports
**/target/checkstyle-*
- name: Upload test report
uses: actions/upload-artifact@v3
# Always upload the test report for the annotate.yml workflow,
# but only the single XML file to keep the artifact small
if: always()
with:
# Name prefix is checked in the `Annotate checks` workflow
name: test report ${{ github.job }} (${{ matrix.config }})
path: |
**/surefire-reports/TEST-*.xml
retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
- name: Upload heap dump
uses: actions/upload-artifact@v3
if: failure() && env.SECRETS_PRESENT == '' && github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository
with:
name-suffix: ${{ github.job }} (${{ matrix.config }})
test-report-retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
name: heap dump ${{ github.job }} (${{ matrix.config }})
if-no-files-found: 'ignore'
path: |
**/*.hprof
retention-days: ${{ env.HEAP_DUMP_RETENTION_DAYS }}
- name: Clean local Maven repo
# Avoid creating a cache entry because this job doesn't download all dependencies
if: steps.cache.outputs.cache-hit != 'true'
Expand All @@ -290,6 +346,8 @@ jobs:
test-other-modules:
runs-on: ubuntu-latest
timeout-minutes: 60
env:
SECRETS_PRESENT: ${{ secrets.SECRETS_PRESENT }}
steps:
- uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -331,9 +389,35 @@ jobs:
!:trino-sqlserver,
!:trino-test-jdbc-compatibility-old-server,
!:trino-tests'
- uses: ./.github/actions/upload
- name: Upload test results
uses: actions/upload-artifact@v3
# Upload all test reports only on failure, because the artifacts are large
if: failure()
with:
name: result ${{ github.job }}
path: |
**/target/surefire-reports
**/target/checkstyle-*
- name: Upload test report
uses: actions/upload-artifact@v3
# Always upload the test report for the annotate.yml workflow,
# but only the single XML file to keep the artifact small
if: always()
with:
# Name prefix is checked in the `Annotate checks` workflow
name: test report ${{ github.job }}
path: |
**/surefire-reports/TEST-*.xml
retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
- name: Upload heap dump
uses: actions/upload-artifact@v3
if: failure() && env.SECRETS_PRESENT == '' && github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository
with:
test-report-retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
name: heap dump ${{ github.job }}
if-no-files-found: 'ignore'
path: |
**/*.hprof
retention-days: ${{ env.HEAP_DUMP_RETENTION_DAYS }}
- name: Clean local Maven repo
# Avoid creating a cache entry because this job doesn't download all dependencies
if: steps.cache.outputs.cache-hit != 'true'
Expand Down Expand Up @@ -412,6 +496,8 @@ jobs:
fail-fast: false
matrix: ${{ fromJson(needs.build-test-matrix.outputs.matrix) }}
timeout-minutes: 60
env:
SECRETS_PRESENT: ${{ secrets.SECRETS_PRESENT }}
Comment thread
hashhar marked this conversation as resolved.
steps:
- uses: actions/checkout@v3
with:
Expand Down Expand Up @@ -504,10 +590,35 @@ jobs:
# ", :, <, >, |, *, ?, \, / are not allowed in artifact names, replace it with an underscore
name=$(echo -n "${{ matrix.modules }}" | sed -e 's/[":<>|\*\?\\\/]/_/g')
echo "ARTIFACT_NAME=$name" >> $GITHUB_ENV
- uses: ./.github/actions/upload
- name: Upload test results
uses: actions/upload-artifact@v3
# Upload all test reports only on failure, because the artifacts are large
if: failure()
with:
name: result ${{ env.ARTIFACT_NAME }}
path: |
**/target/surefire-reports
**/target/checkstyle-*
- name: Upload test report
uses: actions/upload-artifact@v3
# Always upload the test report for the annotate.yml workflow,
# but only the single XML file to keep the artifact small
if: always()
with:
# Name prefix is checked in the `Annotate checks` workflow
name: test report ${{ github.job }} (${{ env.ARTIFACT_NAME }})
path: |
**/surefire-reports/TEST-*.xml
retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
- name: Upload heap dump
uses: actions/upload-artifact@v3
if: failure() && env.SECRETS_PRESENT == '' && github.event_name == 'pull_request' && github.event.pull_request.head.repo.full_name != github.repository
with:
name-suffix: ${{ env.ARTIFACT_NAME }}
test-report-retention-days: ${{ env.TEST_REPORT_RETENTION_DAYS }}
name: heap dump ${{ github.job }} (${{ env.ARTIFACT_NAME }})
if-no-files-found: 'ignore'
path: |
**/*.hprof
retention-days: ${{ env.HEAP_DUMP_RETENTION_DAYS }}
- name: Clean local Maven repo
# Avoid creating a cache entry because this job doesn't download all dependencies
if: steps.cache.outputs.cache-hit != 'true'
Expand Down