Set required env vars for build-pt CI job#15145
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Nov 24, 2022
Merged
Conversation
Closed
ebyhr
reviewed
Nov 22, 2022
When running on PRs from forks, with changes only in submodules, the build-pt job needs to describe all product test environments and all required variables need to be set. Some were renamed in 8a4e55c. This commit makes them consistent.
nineinchnick
force-pushed
the
ci-set-envs-in-build-pt
branch
from
badf5fd to
4f38828
Compare
findepi
approved these changes
Nov 23, 2022
Member
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running on PRs from forks, with changes only in submodules, the build-pt job needs to describe all product test environments and all required variables need to be set. Some were renamed in 8a4e55c (#15011).
Fixes #15143
Additional context and related issues
n/a
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: