Fix resource leak in TestInformationSchemaMetadata#15133
Merged
findepi merged 2 commits intotrinodb:masterfrom Nov 22, 2022
Merged
Conversation
Every JMH benchmark class should have a `@Test` test method ensuring the benchmark continues to work.
Also, avoid allocating resources in test constructor. This is really bad idea.
findepi
added
test
no-release-notes
hashhar
approved these changes
Nov 21, 2022
ebyhr
approved these changes
Nov 21, 2022
Member
Author
|
CI #14445 |
findepi
deleted the
findepi/fix-resource-leak-in-testinformationschemametadata-5daa66
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, avoid allocating resources in test constructor. This is really bad
idea.