Add code comment for StuckSplitTasksInterrupter race condition#15116
Merged
phd3 merged 1 commit intotrinodb:masterfrom Nov 28, 2022
Merged
Add code comment for StuckSplitTasksInterrupter race condition#15116phd3 merged 1 commit intotrinodb:masterfrom
phd3 merged 1 commit intotrinodb:masterfrom
Conversation
phd3
reviewed
Nov 21, 2022
core/trino-main/src/main/java/io/trino/execution/SqlTaskManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/SqlTaskManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/executor/TaskExecutor.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/executor/TaskExecutor.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/executor/TaskExecutor.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/executor/TaskExecutor.java
Outdated
Show resolved
Hide resolved
phd3
reviewed
Nov 21, 2022
core/trino-main/src/main/java/io/trino/execution/SqlTaskManager.java
Outdated
Show resolved
Hide resolved
Member
|
cc @arhimondr |
groupcache4321
force-pushed
the
StuckSplitTasksInterrupter
branch
from
f19ab13 to
611f96b
Compare
Contributor
Author
|
updated thanks! |
phd3
force-pushed
the
StuckSplitTasksInterrupter
branch
from
611f96b to
5d8f0be
Compare
phd3
approved these changes
Nov 28, 2022
Member
phd3
left a comment
phd3
left a comment
There was a problem hiding this comment.
Made some minor language changes, will merge after CI goes through
Member
|
hit #14814, before the fix was merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add code comment for StuckSplitTasksInterrupter race condition.
More details at #13272
Additional context and related issues
#13272
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: