Allow Iceberg writes to use either append or fastAppend #15094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electrum
reviewed
Nov 18, 2022
Member
electrum
left a comment
electrum
left a comment
There was a problem hiding this comment.
Thanks for the contribution. A few minor comments, otherwise looks good.
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergSessionProperties.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
electrum
reviewed
Nov 18, 2022
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergSessionProperties.java
Outdated
Show resolved
Hide resolved
ebyhr
reviewed
Nov 22, 2022
Member
ebyhr
left a comment
ebyhr
left a comment
There was a problem hiding this comment.
Please squash commits into one.
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
Outdated
Show resolved
Hide resolved
alexjo2144
reviewed
Nov 22, 2022
Member
alexjo2144
left a comment
alexjo2144
left a comment
There was a problem hiding this comment.
Nice, thanks for picking this up
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergSessionProperties.java
Outdated
Show resolved
Hide resolved
SergeySereda0218
force-pushed
the
allow_iceberg_writes_to_use_either_append_or_fastappend
branch
6 times, most recently
from
63623f0 to
3f5f096
Compare
SergeySereda0218
force-pushed
the
allow_iceberg_writes_to_use_either_append_or_fastappend
branch
from
3f5f096 to
995dc42
Compare
Contributor
Author
|
Hi. |
ebyhr
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #14822
Allow Iceberg writes to use either append or fastAppend. Users in certain use cases may want to do compaction of Manifests async from writes. We should allow configuring fastAppend for that situation on a session level basis.
Additional context and related issues
New IcebergSessionProperty iceberg.merge_manifests_on_write . Default value - "true".
SET SESSION iceberg.merge_manifests_on_write = false to force fastAppend()
SET SESSION iceberg.merge_manifests_on_write = true to force append()
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:
Iceberg
14822)# Section