Fix the order of parameters listed by DESCRIBE INPUT#15086
Closed
kasiafi wants to merge 2 commits intotrinodb:masterfrom
Closed
Fix the order of parameters listed by DESCRIBE INPUT#15086kasiafi wants to merge 2 commits intotrinodb:masterfrom
kasiafi wants to merge 2 commits intotrinodb:masterfrom
Conversation
Before this change, if a prepared query contained a CTE, the parameters from the CTE were listed last by DESCRIBE INPUT, preceded by all parameters from the enclosing query. It was incorrect, since CTE is first in the query text. This fix changes the order in which the CTE and the enclosing query body are visited in the AST builder, thus changing the order of parameters in the DESCRIBE INPUT result.
Member
|
How does it relate to #14914 ? |
Member
Author
Oh, I missed that PR, and the issue. I was addressing the same problem. My approach was easier and less general though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change, if a prepared query contained a CTE,
the parameters from the CTE were listed last by DESCRIBE
INPUT, preceded by all parameters from the enclosing query.
It was incorrect, since CTE is first in the query text.
This fix changes the order in which the CTE and the enclosing
query body are visited in the AST builder, thus changing the
order of parameters in the DESCRIBE INPUT result.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: