Allow Coercion between hive Union and hive struct for Hive ORC table#15017
Merged
phd3 merged 2 commits intotrinodb:masterfrom Jan 17, 2023
Merged
Allow Coercion between hive Union and hive struct for Hive ORC table#15017phd3 merged 2 commits intotrinodb:masterfrom
phd3 merged 2 commits intotrinodb:masterfrom
Conversation
groupcache4321
force-pushed
the
UnionAsStruct
branch
from
90c345b to
698aa3b
Compare
phd3
reviewed
Nov 16, 2022
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HivePageSource.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveCoercionPolicy.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveCoercionPolicy.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveSplitManager.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestReadUniontype.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestReadUniontype.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestReadUniontype.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestReadUniontype.java
Outdated
Show resolved
Hide resolved
Member
groupcache4321
force-pushed
the
UnionAsStruct
branch
from
698aa3b to
a52d696
Compare
groupcache4321
force-pushed
the
UnionAsStruct
branch
from
a52d696 to
ba8ea5f
Compare
groupcache4321
changed the title
phd3
reviewed
Dec 4, 2022
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveSplitManager.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HivePageSource.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HiveType.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveCoercionPolicy.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveCoercionPolicy.java
Outdated
Show resolved
Hide resolved
groupcache4321
force-pushed
the
UnionAsStruct
branch
from
2d04ac6 to
c76b8bb
Compare
groupcache4321
force-pushed
the
UnionAsStruct
branch
3 times, most recently
from
6a9dbc3 to
f7a2959
Compare
Contributor
Author
|
hi, I updated the PR, it is ready to review. Rebase on latest master branch, which include changes from: #15278 |
phd3
approved these changes
Jan 5, 2023
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveCoercionPolicy.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/util/HiveCoercionPolicy.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestReadUniontype.java
Outdated
Show resolved
Hide resolved
testing/trino-product-tests/src/main/java/io/trino/tests/product/hive/TestReadUniontype.java
Outdated
Show resolved
Hide resolved
plugin/trino-hive/src/main/java/io/trino/plugin/hive/HivePageSource.java
Outdated
Show resolved
Hide resolved
groupcache4321
force-pushed
the
UnionAsStruct
branch
from
f7a2959 to
e549436
Compare
Contributor
Author
|
Hi, it has been updated, please take a further look. |
phd3
approved these changes
Jan 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow Coercion between hive Union and hive struct, at LinkedIn we have the need to declare the table schema as struct and reading some partitions in union definition.
Since Trino internally treat union as struct, this PR allows coercions between struct and union(after union get converted to Struct)
Related PR:
#3483
e071da4
Non-technical explanation
Allow Coercion between hive Union and hive struct
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: