Fix failure when BigQuery row access policy return empty result#14986
Merged
Fix failure when BigQuery row access policy return empty result#14986
Conversation
hashhar
approved these changes
Nov 10, 2022
Member
There was a problem hiding this comment.
should this be in a finally block (in addition to in the test) to avoid leaking policies when assertion fails?
Or do policies go away as tables get dropped?
Member
Author
There was a problem hiding this comment.
I couldn't find the official docs about it, but policies go away when dropping tables as far as I confirmed.
ebyhr
force-pushed
the
ebi/bigquery-access-policy
branch
from
8a9fb29 to
5c8c80b
Compare
Member
Author
|
Added a missing |
ebyhr
force-pushed
the
ebi/bigquery-access-policy
branch
from
5c8c80b to
63c0904
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #14760
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: