Document the DML operations support on GCS#14985
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Nov 18, 2022
Merged
Conversation
colebow
reviewed
Nov 11, 2022
Member
There was a problem hiding this comment.
If this is treated the same as Azure ADLS, we can probably combine them into one bullet point, e.g. * Azure ADLS Gen2, Google Cloud Storage
Then "Writes to the Azure ALDS Gen2 and Google Cloud Storage file systems are enabled..."
Comment on lines
566
to
567
Member
There was a problem hiding this comment.
Suggested change
| detects write collisions on ADLS Gen2 when writing from multiple Trino | |
| clusters, or from as any number of open source Delta Lake clusters. | |
| detects write collisions on ADLS Gen2 when writing from multiple Trino | |
| or Delta Lake clusters. |
I can't figure out what this is trying to say and I don't think we need to tell people that Delta Lake is open source here, so let's clean it up.
Contributor
Author
There was a problem hiding this comment.
I rewrote a bit this statement to be a bit more concise, but still tried to keep its essence.
b312cc2 to
5966a0f
Compare
colebow
approved these changes
Nov 15, 2022
ebyhr
approved these changes
Nov 16, 2022
5966a0f to
862b18f
Compare
862b18f to
ca606ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Left-over docs change for Delta DML operation support on GCS from #14766
Non-technical explanation
N/A
Release notes
(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: