Load TPCH dataset into BigQuery using Trino#14982
Merged
Conversation
Since Trino now supports writes to BigQuery we can directly create required TPCH tables instead of having to load them manully beforehand.
In previous commit 90f518f BigQuery connector now uses Trino to create the TPCH dataset and hence the external script and schemas are no longer needed.
ebyhr
approved these changes
Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
BigQuery connector now supports writes so we can directly load the TPCH dataset instead of using external scripts.
Release notes
(x) This is not user-visible or docs only and no release notes are required.
Fixes #14338
This uncovered #14981 because the
copyTpchTablesmethod failed when verifying count of inserted rows on newly created tables.