Decrease size of product-tests-launcher jar#14974
Conversation
There was a problem hiding this comment.
Also, by their design, prroduct tests should be "black box". They intentionally never depended on the trino-main.
Can you perhaps enhance the comment to indicate that too?
Also, why does the plugin reader pull trino-main?
Is it a fake dep? Does plugin reader combine different functionalities, some depending on trino-main and some not? maybe plugin reader should be two separate modules?
There was a problem hiding this comment.
PluginReader uses this single function from trino-main - extractFunctions: https://github.com/trinodb/trino/blob/master/testing/trino-plugin-reader/src/main/java/io/trino/server/PluginReader.java#L136
The product tests launcher only needs a few constants from the plugin reader. It definitely feels like something should be moved to improve dependencies, but I'm not sure what.
There was a problem hiding this comment.
The product tests launcher only needs a few constants from the plugin reader. I
Can we move these constants out to trino-plugin-reader-{api,spi,something} jar?
There was a problem hiding this comment.
Yeah - it crossed my mind too. I was not convinced that we want extra module just for that. Probably the cleanest approach still.
I will merge this one as a stop-gap though.
losipiuk
force-pushed
the
lo/smaller-launcher
branch
from
f4df17d to
fcbb44b
Compare
3 participants
Decrease size of product-tests-launcher jar## Release notes
(s) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: