Skip to content

Use assertThatThrownBy in TestFileBasedSystemAccessControl #14965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ebyhr merged 1 commit into from
Nov 9, 2022
Merged

Use assertThatThrownBy in TestFileBasedSystemAccessControl #14965

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 16 additions & 44 deletions core/trino-main/src/test/java/io/trino/security/TestFileBasedSystemAccessControl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,30 +92,18 @@ public void testCanImpersonateUserOperations()
accessControlManager.checkCanImpersonateUser(Identity.ofUser("admin"), "bob");
accessControlManager.checkCanImpersonateUser(Identity.ofUser("admin"), "anything");
accessControlManager.checkCanImpersonateUser(Identity.ofUser("admin-other"), "anything");
try {
accessControlManager.checkCanImpersonateUser(Identity.ofUser("admin-test"), "alice");
throw new AssertionError("expected AccessDeniedException");
}
catch (AccessDeniedException expected) {
}
assertThatThrownBy(() -> accessControlManager.checkCanImpersonateUser(Identity.ofUser("admin-test"), "alice"))
.isInstanceOf(AccessDeniedException.class);

try {
accessControlManager.checkCanImpersonateUser(Identity.ofUser("invalid"), "alice");
throw new AssertionError("expected AccessDeniedException");
}
catch (AccessDeniedException expected) {
}
assertThatThrownBy(() -> accessControlManager.checkCanImpersonateUser(Identity.ofUser("invalid"), "alice"))
.isInstanceOf(AccessDeniedException.class);

accessControlManager.checkCanImpersonateUser(Identity.ofUser("anything"), "test");
try {
accessControlManager.checkCanImpersonateUser(Identity.ofUser("invalid-other"), "test");
throw new AssertionError("expected AccessDeniedException");
}
catch (AccessDeniedException expected) {
}
assertThatThrownBy(() -> accessControlManager.checkCanImpersonateUser(Identity.ofUser("invalid-other"), "test"))
.isInstanceOf(AccessDeniedException.class);

accessControlManager = newAccessControlManager(transactionManager, "catalog_principal.json");
accessControlManager.checkCanImpersonateUser(Identity.ofUser("anything"), "anythingElse");
AccessControlManager accessControlManagerWithPrincipal = newAccessControlManager(transactionManager, "catalog_principal.json");
accessControlManagerWithPrincipal.checkCanImpersonateUser(Identity.ofUser("anything"), "anythingElse");
}

@Test
Expand Down Expand Up @@ -144,38 +132,22 @@ public void testCanSetUserOperations()
TransactionManager transactionManager = createTestTransactionManager();
AccessControlManager accessControlManager = newAccessControlManager(transactionManager, "catalog_principal.json");

try {
accessControlManager.checkCanSetUser(Optional.empty(), alice.getUser());
throw new AssertionError("expected AccessDeniedExeption");
}
catch (AccessDeniedException expected) {
}
assertThatThrownBy(() -> accessControlManager.checkCanSetUser(Optional.empty(), alice.getUser()))
.isInstanceOf(AccessDeniedException.class);

accessControlManager.checkCanSetUser(kerberosValidAlice.getPrincipal(), kerberosValidAlice.getUser());
accessControlManager.checkCanSetUser(kerberosValidNonAsciiUser.getPrincipal(), kerberosValidNonAsciiUser.getUser());
try {
accessControlManager.checkCanSetUser(kerberosInvalidAlice.getPrincipal(), kerberosInvalidAlice.getUser());
throw new AssertionError("expected AccessDeniedExeption");
}
catch (AccessDeniedException expected) {
}
assertThatThrownBy(() -> accessControlManager.checkCanSetUser(kerberosInvalidAlice.getPrincipal(), kerberosInvalidAlice.getUser()))
.isInstanceOf(AccessDeniedException.class);

accessControlManager.checkCanSetUser(kerberosValidShare.getPrincipal(), kerberosValidShare.getUser());
try {
accessControlManager.checkCanSetUser(kerberosInValidShare.getPrincipal(), kerberosInValidShare.getUser());
throw new AssertionError("expected AccessDeniedExeption");
}
catch (AccessDeniedException expected) {
}
assertThatThrownBy(() -> accessControlManager.checkCanSetUser(kerberosInValidShare.getPrincipal(), kerberosInValidShare.getUser()))
.isInstanceOf(AccessDeniedException.class);

accessControlManager.checkCanSetUser(validSpecialRegexWildDot.getPrincipal(), validSpecialRegexWildDot.getUser());
accessControlManager.checkCanSetUser(validSpecialRegexEndQuote.getPrincipal(), validSpecialRegexEndQuote.getUser());
try {
accessControlManager.checkCanSetUser(invalidSpecialRegex.getPrincipal(), invalidSpecialRegex.getUser());
throw new AssertionError("expected AccessDeniedExeption");
}
catch (AccessDeniedException expected) {
}
assertThatThrownBy(() -> accessControlManager.checkCanSetUser(invalidSpecialRegex.getPrincipal(), invalidSpecialRegex.getUser()))
.isInstanceOf(AccessDeniedException.class);

AccessControlManager accessControlManagerNoPatterns = newAccessControlManager(transactionManager, "catalog.json");
accessControlManagerNoPatterns.checkCanSetUser(kerberosValidAlice.getPrincipal(), kerberosValidAlice.getUser());
Expand Down