Remove deprecated page sink creation methods#14959
Merged
losipiuk merged 2 commits intotrinodb:masterfrom Nov 14, 2022
Merged
Conversation
losipiuk
force-pushed
the
lo/cleanup-task-id
branch
from
640f920 to
5a58c56
Compare
losipiuk
force-pushed
the
lo/cleanup-task-id
branch
from
5a58c56 to
497f28f
Compare
findepi
approved these changes
Nov 14, 2022
Member
core/trino-spi/pom.xml
Outdated
Member
There was a problem hiding this comment.
Shouldn't this be allowed under deprecation policy, i.e. without requiring an entry in pom.xml?
Member
Author
There was a problem hiding this comment.
IDK - it did complain in build
losipiuk
force-pushed
the
lo/cleanup-task-id
branch
from
497f28f to
97826b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text:
fixes #14705