Use Guice binding CatalogName in connectors#14951
Merged
kokosing merged 1 commit intotrinodb:masterfrom Nov 9, 2022
Merged
Conversation
mx123
force-pushed
the
connectors_catalog_name_guice_binding
branch
from
f7f3018 to
864d878
Compare
kokosing
approved these changes
Nov 8, 2022
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcConnectorFactory.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcConnectorFactory.java
Outdated
Show resolved
Hide resolved
mx123
force-pushed
the
connectors_catalog_name_guice_binding
branch
from
864d878 to
bf9df6d
Compare
hashhar
approved these changes
Nov 8, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
I wonder what would change with dynamic catalogs being introduced.
plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcConnectorFactory.java
Show resolved
Hide resolved
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use Guice binding CatalogName in connectors since it provides within Guice connectors context.